Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heimdall timeout configurable #1455

Open
manav2401 opened this issue Feb 19, 2025 · 1 comment
Open

Make heimdall timeout configurable #1455

manav2401 opened this issue Feb 19, 2025 · 1 comment
Assignees

Comments

@manav2401
Copy link
Contributor

manav2401 commented Feb 19, 2025

Rationale

There's a hard coded timeout of 5s in bor when we fetch data from heimdall via api. John suggested to make it configurable as public endpoints might take more time (although it's not recommended to use public endpoints).

apiHeimdallTimeout = 5 * time.Second
retryCall = 5 * time.Second

Implementation

Add a new flag and pass it across bor to configure it.

@lucca30 lucca30 self-assigned this Feb 19, 2025
@marcello33
Copy link
Contributor

PR to be reviewed and possibly merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants