Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notification text #294

Open
martinrieder opened this issue Jul 3, 2024 · 3 comments
Open

Change notification text #294

martinrieder opened this issue Jul 3, 2024 · 3 comments
Labels
enhancement new feature

Comments

@martinrieder
Copy link

martinrieder commented Jul 3, 2024

The notification feature is really great, though I would like to request some improvements to make it even greater:

regular work time is over since...

Should be changed to this:

Flexi time is over since...
Work time is over since...

Because:

  • The additional info is crucial if you need to work some minimum hours every day
  • Text "regular work time" seems misleading if it includes the flex time
  • Notification string is currently too long, so the time is hidden when minimized

Additionally, I propose to change the title if even more details are required:

Worked (time) hours since (clock-in)

Then in the notification text also add the two stop times:

Flexi time (was/is) reached (in/since) (time) at (flexi-out) ...
Work time (was/is) reached (in/since) (time) at (clock-out) ...
@mathisdt mathisdt added the enhancement new feature label Jul 4, 2024
@mathisdt
Copy link
Owner

mathisdt commented Jul 4, 2024

ℹ️ There are two different notification texts, the standard text is changed every minute but the "minimal text" is only activated once (so the re-notification doesn't get on the user's nerves, this was a problem for some people). The option "never update persistent notification" activates the minimal notification text, which also should be adapted accordingly when implementing this!

@martinrieder
Copy link
Author

martinrieder commented Jul 6, 2024

Thanks, I was not aware of that, but it makes sense. I think that the messages that I mentioned as additional proposal should be chosen according to that setting. The text should be kept short to avoid clipping anyways...

Additionally, I propose to change the title if even more details are required:

Worked (time) hours since (clock-in)

Then in the notification text also add the two stop times:

Flexi time (was/is) reached (in/since) (time) at (flexi-out) ...
Work time (was/is) reached (in/since) (time) at (clock-out) ...

Updated every minute:
Worked (time) hours

  • Flexi time (was/is) reached (in/since) (time)
  • Work time (was/is) reached (in/since) (time)

Updated only at clock-in, clock-out or flexi-out:
Clocked in since (clock-in)

  • Flexi time (was/is) reached at (flexi-out)
  • Work time (was/is) reached at (clock-out)

I am not sure if users need to see both times. Therefore I suggest that the notification should choose the time that comes first.
It would also be possible to simply provide two independent notifications (for flex and work) that could be treated separately.

PS: The text of the respective setting could also be clarified.
Instead of "never update persistent notification", I suggest writing "Update on events only".

@martinrieder
Copy link
Author

I wrote:

It would also be possible to simply provide two independent notifications (for flex and work) that could be treated separately.

In case that there are two or more clock-in events, i.e. when the setting "Handle methods separately" is active, the I reckon that there must be multiple notifications active.

This thought leads me to extend the notification title by the name of the active task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature
Projects
None yet
Development

No branches or pull requests

2 participants