Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Bad Warning in Builders #526

Open
shyamd opened this issue Dec 13, 2021 · 0 comments
Open

Bug: Bad Warning in Builders #526

shyamd opened this issue Dec 13, 2021 · 0 comments
Assignees

Comments

@shyamd
Copy link
Contributor

shyamd commented Dec 13, 2021

MapBuilder, GroupBuilder, and ProjectionBuilder all have this ensure index warning that is not a good description of what actually went "wrong". It basically warns that one double index is missing when in fact the check is for all relevant indexes: key, last_updated and state; these are also not double indexes. Would be good to update the warning. Here is the linked code:

if not all(index_checks):
self.logger.warning(
"Missing one or more important indices on stores. "
"Performance for large stores may be severely degraded. "
"Ensure indices on target.key and "
"[(store.last_updated_field, -1), (store.key, 1)] "
"for each of source and target."
)

@munrojm munrojm self-assigned this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants