Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node limits in provenance browser #13

Open
2 of 3 tasks
ltalirz opened this issue Sep 19, 2019 · 2 comments
Open
2 of 3 tasks

node limits in provenance browser #13

ltalirz opened this issue Sep 19, 2019 · 2 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Sep 19, 2019

There are a few ways how the current hard node limit (applying to the total number of input and output nodes) could be improved

  • if possible, limit data requested from rest api (currently we still request all nodes, even if we just display 20). this could potentially significantly improve speed
  • consider making node limit act on input/output nodes separately (so that e.g. if the number of output nodes are low, all will be shown)
  • when the node limit is exceeded, consider displaying, together with the warning, a button to show all nodes (or make it otherwise configurable)

In my view, none of these items are super urgent.

@waychal
Copy link
Member

waychal commented Apr 29, 2020

In REST API tree endpoint one can use in_limit and out_limit filters to get limited number of incoming and outgoing nodes. Currently in Explore section this number is configured as 10.

e.g.
https://dev-www.materialscloud.org/2dtopo/api/v2/nodes/4c1e1147-a0fa-4111-afe5-ffebeb4eba74/io/tree?in_limit=10&out_limit=10

https://dev-aiida-dev.materialscloud.org/hcofs-co2/api/v4/nodes/6dbfa91f-b698-4958-86bb-d2df7d24b16b/links/tree?in_limit=10&out_limit=10

The response json is changed from version v2 to v4.

@ltalirz
Copy link
Member Author

ltalirz commented Apr 29, 2020

Fantastic, so the first two points are already taken care of!

@ltalirz ltalirz transferred this issue from another repository Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants