[RFC] Replace character counter "data-length" attribute #380
Closed
mauromascarenhas
started this conversation in
Ideas
Replies: 1 comment
-
Yes, sounds good! 👍 I am looking forward and would review the PR! :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello guys, I'd like to propose a breaking change for CharacterCounter component.
The thing is:
input
andtextarea
elements already have a "maxlength" (textarea#maxlength) attribute. Thus, I believe that the "data-length" attribute could be deprecated in favour of this standard attribute, since it is semantically correct, provides better support to field validation and is better handled by assistive technologies (eg.: screen readers).I already have a branch prepared to make a PR if you guys agree with this change (since v2 is still in alpha, this breaking change would not be a major issue).
Beta Was this translation helpful? Give feedback.
All reactions