Remove theme attribute from wp:template-part tags #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR fixes an issue where the homepage returned the
Template part has been deleted or is unavailable
error when enabling another theme.This issue was caused by the theme attribute being included in the wp:template-part tags for the header and footer of the home template.
A similar issue was detailed in WordPress/create-block-theme#242, which is where I identified the fix.
Closes (GitHub issue number or Asana task link)
Pre-submit checklist
As the author of this pull request, I verify that:
master
.Testing
How to test the changes in this pull request
Follow the steps below to test the changes in this PR.
dev
environment.Functional tests
As the functional tester for this pull request, I verify that:
Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana. If all tests pass, move the task to "Ready for Code Review" in Asana and tag a team member for code review.
Code review
As the code reviewer for this pull request, I verify that:
Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana or continue with the "merging" steps below.
Merging
As the individual merging this pull request, I verify that:
┆Issue is synchronized with this Asana task