Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Do we want to add more variables that correspond with mastodon configuration, or a single variable for arbitrary config? #52

Open
ineffyble opened this issue Dec 3, 2022 · 3 comments

Comments

@ineffyble
Copy link
Member

Question for maintainers of this repo:

Would we rather add more optional variables that correspond with Mastodon configuration variables?

Or do we think maintaining those is an unnecessary overhead, and we'd rather have an extra_mastodon_config variable that lets the user define arbitrary key-value pairs to add to .env.production?

@ineffyble
Copy link
Member Author

@thunderysteak @romaricpascal @moritzheiber would love your thoughts here before I create any such PRs.

@thunderysteak
Copy link
Contributor

I believe that extra_mastodon_config would be more ideal to add more arbitrary config options to .env.production

@digitalcircuit
Copy link

On a related note, I'm looking to set up S3_ALIAS_HOST as per the documentation, and there's this remark:

It is extremely recommended to use your own host instead, for a few reasons:

  1. Bandwidth on external storage providers is metered and expensive
  2. You may want to switch to a different provider later without breaking old links

Would this be sufficient reasoning to make a PR to have it as a dedicated entry for S3_ALIAS_HOST in variables.yml?

From what I understand, this cannot be changed after deployment and it requires additional nginx configuration to proxy object storage, so perhaps this should be handled differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants