Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clunky --output-format behaviour when running --convert #24

Closed
CodeF0x opened this issue Feb 4, 2025 · 1 comment · Fixed by #34
Closed

Clunky --output-format behaviour when running --convert #24

CodeF0x opened this issue Feb 4, 2025 · 1 comment · Fixed by #34
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@CodeF0x
Copy link
Contributor

CodeF0x commented Feb 4, 2025

When running --convert, e.g. with dotnet .\FFMP.dll -d 'C:\Users\Tobi\Videos\DerEinziche\' --output-format "watermark_{{name}}.mp4" --convert, there are some inconsistencies:

  • --output-pattern needs to be replaced with --output-format. I get what's its trying to achieve, but now placeholders won't work anymore
  • --convert writes all processed files into the same directory the source files are at. You end up with seemingly every file twice, as the only difference is the file extension

My proposal is to re-use --output-pattern because:

  • it allows you to use the extensive templating syntax
  • you're able to specify a different output directory from the input directory
  • rather specific use cases like adding a watermark can be served as well. When doing that with --convert, you'll end up with the "the files look identical on first glance" problem, and without you're forced to supply --codec what re-encodes the file unnecessarily
@CodeF0x
Copy link
Contributor Author

CodeF0x commented Feb 5, 2025

Another issue with --output-format is that --output-pattern and --output-format are not validated mutually exclusive which can lead to confusion as in #22

@massimo-rnd massimo-rnd self-assigned this Feb 5, 2025
@massimo-rnd massimo-rnd added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 5, 2025
@massimo-rnd massimo-rnd added this to the FFMP v2.0 milestone Feb 5, 2025
@massimo-rnd massimo-rnd linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants