-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade
unable to parse response json
#493
Comments
I'm still having this issue. I assume MAS is no longer supported? Are there any viable alternatives? |
I got the same issue, but after |
Is this still occurring? If so, please provide the outputs of both:
|
For me, it's not reproducible anymore 😫 . But it was reproduced on the first install. After I used Here is the list of app
|
@Goralive Thanks. After some other issues are fixed, we should try to provide better error output from mas. For unparsable JSON errors, we should output the unparsable JSON after the error message so that we can investigate more easily. If the JSON is very long, maybe the JSON should be output only if a new |
yeah, it would be really great 💯 to have in the output this option. So I have installed it on other MacBooks, but all the stuff is up to date... So for me can't reproduce. Maybe @brokosz have a steps |
I gave up on mas due to the errors, but let me try again today. I'll post output here as well when I get into the office. |
@brokosz Thanks |
yay - success!
|
Looks like the immediate reaction should be to output the unparsable JSON. Once that's in place, if anyone experiences the same problem, then we'll be able to investigate better. But there won't be much else that can be done until someone else encounters the same error. |
I've been getting the same error and also can't help diagnose because mas doesn't output the json. Imo it shouldn't be behind a debug flag because it's an error. Fwiw, it seems to be related to the Amazon Kindle app.
The problem started when I added Kindle to my Brewfile, and commenting out that line in my Brewfile fixed it. Plus I see someone above has Kindle installed as well. The app is doing something weird where it's always thinking it needs updating, so it may be related to that. |
@kbd I installed 'Amazon Kindle' 302584613 from the Mac App Store GUI. I do not get any errors from I haven't used Brewfiles directly, so maybe the issue is with installing using a Brewfile or using I'm running macOS 12.7.6 on Intel. I tried a few different versions of mas, none of which output any errors. |
upgrade
unable to parse response json
Its seemingly buggy update behavior seems to be bugging out 'mas': mas-cli/mas#493 (comment)
@kbd @brokosz @Goralive @joshuaclayton The code in the GitHub Can you first try to replicate the problem with the existing mas stable version 1.8.6? It won't display any response that isn't parsable as JSON, but it will let us know if the problem still exists on 1.8.6z Then can you test what's in brew install --HEAD mas That will let us see if the problem was luckily fixed by any of the many changes in Thanks for any help investigating this issue. |
@rgoldberg I have updated to 1.8.7-beta.8 |
@Goralive Thanks for checking. Glad no issue right now, but if anything occurs again, please let us know. |
same - no issues for me right now either. 🤞🏼 |
@brokosz Thanks for the info. Please let us know whenever you experience the problem again. |
I received |
@johnhampton Thanks for the error output. Your parsing error was caused by one search result app missing the The existing JSON parsing is brittle. In my PR for this (#643), these 2 properties are now optional instead of required. The future Output Refactor (#626) will completely revamp how we handle JSON, so missing other properties won't cause any problems when that is done, but that won't be worked on / completed for some time. In the meantime, #643 has been merged into the It won't be released to the public until the next mas version release (presumably 1.8.8), which might take a few weeks. You can test it out (as long as you have Xcode 14.2+ so you can build mas from source) by installing mas from the brew uninstall mas
brew install --HEAD mas If you still experience the error, please let us know. If anyone experiences any other parsing issues, please open a new issue (and please try the code from |
@rgoldberg - no further issues for me. everything still seems to be working properly. 👍🏼 |
Your Environment
mas Install Method
brew install mas
(homebrew-core)Describe the Bug
To Reproduce
mas upgrade
will throw the error every timeExpected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: