Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve addmethodnode #36

Merged
merged 50 commits into from
Dec 4, 2024
Merged

Improve addmethodnode #36

merged 50 commits into from
Dec 4, 2024

Conversation

thomvet
Copy link
Collaborator

@thomvet thomvet commented Nov 18, 2024

This introduces high level interface functions for convenient adding and calling of method nodes.

Short summary below:

  • Introduce JUA_Argument wrappers for UA_Argument
  • Tests for JUA_Argument
  • Rethink and implement JUA_Sever_addNode(...) for method nodes.
  • Tests for JUA_Server_addNode
  • JUA_Client_call making calling method nodes using the client api easier.
  • Tests for JUA_Client_call
  • JUA_Server_call making calling method nodes using the server api easier.
  • Tests for JUA_Server_call
  • Docstrings for everything
  • Improve error messages for ValueRankArraySizeConsistencyError
  • Tutorial how to add method nodes to server and how to call them via Server and Client API.

@thomvet
Copy link
Collaborator Author

thomvet commented Nov 19, 2024

The failing testset works on [email protected] ([email protected]), but not with 1.3.11 - weird. And obviously not with 0.2.0 and 1.4.x.

I am suspecting that the problem is in the upstream library. Will investigate (and post an issue there), but likely mark these tests as broken right now.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 81.18812% with 57 lines in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (acb77e7) to head (e7e97d9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/exceptions.jl 12.00% 22 Missing ⚠️
src/highlevel_types.jl 84.90% 16 Missing ⚠️
src/highlevel_client.jl 87.09% 8 Missing ⚠️
src/client.jl 42.85% 4 Missing ⚠️
src/helper_functions.jl 88.57% 4 Missing ⚠️
src/attribute_generation.jl 77.77% 2 Missing ⚠️
src/highlevel_server.jl 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   42.28%   45.33%   +3.04%     
==========================================
  Files          13       13              
  Lines        4377     4601     +224     
==========================================
+ Hits         1851     2086     +235     
+ Misses       2526     2515      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomvet thomvet self-assigned this Nov 26, 2024
@thomvet thomvet requested a review from martinkosch November 26, 2024 09:51
@thomvet thomvet changed the title [WIP] Improve addmethodnode Improve addmethodnode Nov 26, 2024
@thomvet
Copy link
Collaborator Author

thomvet commented Nov 26, 2024

Ok, all issues worked around; should be ready for review @martinkosch

@thomvet thomvet merged commit 0ad304d into main Dec 4, 2024
8 checks passed
@thomvet thomvet deleted the improve-addmethodnode branch December 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants