Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to work with open62541 v1.4.7 and adapt login tutorial #33

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

thomvet
Copy link
Collaborator

@thomvet thomvet commented Nov 17, 2024

open62541 pushed a new release recently (1.4.7) with the following release notes: https://github.com/open62541/open62541/releases

server: Consider allowNonePolicyPassword in GetEndpoints

Means that the server now actually checks the value of this configuration option. The net result is that one either:

  • puts the above value to true, i.e., allowing to send passwords&usernames unencrypted over the network or
  • keep the above value on false (the default) and one has to have an encryption policy specified.

Obviously, the second option is the safer one. I'll make an appropriate tutorial regarding using encryption soon (and include appropriate tests), but for now it would be great to have the tests pass again as a "quick fix"

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.28%. Comparing base (4861778) to head (08701b6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   40.89%   42.28%   +1.39%     
==========================================
  Files          13       13              
  Lines        4377     4377              
==========================================
+ Hits         1790     1851      +61     
+ Misses       2587     2526      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@thomvet
Copy link
Collaborator Author

thomvet commented Nov 18, 2024

Added a testset where a server and client are configured with encryption. It is then tested that a user using encryption is allowed to connect, while a user trying to connect without encryption is rejected by the server.

Now I only have to add a tutorial where this is put together with the username/password login case that is already there. (hopefully will get to it tonight).

@thomvet thomvet requested a review from martinkosch November 18, 2024 14:46
@thomvet
Copy link
Collaborator Author

thomvet commented Nov 18, 2024

Tutorial added; this is ready for review!

@thomvet thomvet merged commit 8bef1a3 into main Nov 18, 2024
9 checks passed
@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Repository owner deleted a comment from JuliaRegistrator Nov 18, 2024
@thomvet thomvet deleted the bugfix-login-teststutorial branch November 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants