Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional "serviceName" property to all service methods #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add optional "serviceName" property to all service methods #82

wants to merge 1 commit into from

Conversation

kiwi-josh
Copy link

Resolves: #51

Optionally allow serviceName to be provided when calling the methods, defaulting to the existing "cap_sec" if not provided to maintain backwards compatibility

@kiwi-josh kiwi-josh mentioned this pull request Sep 24, 2023
Open
@kiwi-josh
Optionally allow serviceName to be provided when calling the methods,…
3d2e6ca 
… defaulting to the existing "cap_sec" if not provided to maintain backwards compatibility
@de-dan
Copy link

de-dan commented May 8, 2024

+1 but

  • Android implementation missing
  • I get that in the iOS implementation your new serviceName property is actually used as serviceName for the KeychainWrapper, but in Web the property is used for the storage entry key. So I would suggest a more global naming like prefix or keyPrefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add the ability to specify the serviceName
2 participants
@kiwi-josh @de-dan