Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for default email address from config #10

Open
Brixy opened this issue Mar 5, 2020 · 5 comments
Open

Add option for default email address from config #10

Brixy opened this issue Mar 5, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Brixy
Copy link

Brixy commented Mar 5, 2020

I use your brilliant shortcode heavily in many projects. Now I had to change all email addresses in one of them. So this is what I am using now:

In cloakemail.html:

{{- $address := .Get "address" | default .Site.Params.themeSettings.cloakemail -}}

config.yaml:

params:
  themeSettings:
    cloakemail: "[email protected]"
    …

Does this make sense to you? Yet, other user might prefer a default phone number etc. So an address in this format address="emaildefault" might make more sense.

Thank you!

@martignoni
Copy link
Owner

Good idea. Would you prepare a PR for this?

@Brixy
Copy link
Author

Brixy commented Mar 8, 2020

Ok. I am happy to do that. I have that about a good and downward compatible solution. It will take a few days as I am on the road right now.

@martignoni martignoni added the enhancement New feature or request label Mar 8, 2020
@sysadmin-info
Copy link

sysadmin-info commented Mar 17, 2023

I suppose it requires cloakemail.svg

I implemented it and it says

"svgs/social/cloakemail.svg" not found render of "page" failed:

"svgs/social/" $name ".svg") (dict "width" 25 "height" 25)>: partial "svgs/social/cloakemail.svg" not found failed to render pages:

partial "svgs/social/cloakemail.svg" not found

What I did was to find email.svg file copy it as cloakemail.svg.

@martignoni
Copy link
Owner

Absolutely nothing to do with any image. You must be confusing.

@sysadmin-info
Copy link

Absolutely nothing to do with any image. You must be confusing.

the error comes from the zzo theme. Theme is using svg files as icons. Anyway it is made the way it is looking for a proper svg name because it has a pattern defined. So I just copied the email.svg to cloakemail.svg and it did the job. I just thought that someone would like to know how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants