Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash completion broken when using subcommands #72

Open
M0ses opened this issue Jul 15, 2024 · 0 comments · May be fixed by #73
Open

bash completion broken when using subcommands #72

M0ses opened this issue Jul 15, 2024 · 0 comments · May be fixed by #73

Comments

@M0ses
Copy link
Contributor

M0ses commented Jul 15, 2024

After creating a subcommand (e.g. My/App/command/subcommand.pm) bash_completion is broken, as it creates bash function names containing white spaces:

_..._macc_command subcommand() {
....
}

instead of

_..._macc_command_subcommand() {
....
}
@M0ses M0ses changed the title Bashcompletion broken when using subcommands bash completion broken when using subcommands Jul 15, 2024
M0ses added a commit to M0ses/MooseX-App that referenced this issue Jul 15, 2024
@M0ses
Fix bash_completion for subcommands
88c7f9f 
Fixes: maros#72

**Improvements/Fixes:**

* Filter out duplicate entries from `_.*_COMMANDS="..."`
* Do not add subcommands to `_.*_COMMANDS="..."`
* add subcommands at the beginning of `_.*_macc_command` options list
* use `_.*_command_subcommand() { ... }` instead of `_.*_command subcommand() { ... }`
@M0ses M0ses linked a pull request Jul 15, 2024 that will close this issue
Open
M0ses added a commit to M0ses/MooseX-App that referenced this issue Aug 9, 2024
@M0ses
Fix bash_completion for subcommands
0ff1a89 
Fixes: maros#72

**Improvements/Fixes:**

* Filter out duplicate entries from `_.*_COMMANDS="..."`
* Do not add subcommands to `_.*_COMMANDS="..."`
* add subcommands at the beginning of `_.*_macc_command` options list
* use `_.*_command_subcommand() { ... }` instead of `_.*_command subcommand() { ... }`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bashcompletion with subcommands M0ses/MooseX-App
1 participant
@M0ses