Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Warning if Duplicates Detected #484

Open
gerryflux opened this issue Aug 21, 2024 · 4 comments
Open

Feature Request: Warning if Duplicates Detected #484

gerryflux opened this issue Aug 21, 2024 · 4 comments

Comments

@gerryflux
Copy link

I have been enjoying using Binary Eye for about 2 weeks now.
I understand of the Ignore Duplicates and History Feature. Currently when those two features are enabled and a duplicate is detected, it's ignored silently.
The request I'm making is a build-up on these two, if there could be a toggle to allow the app to show a warning pop-up with or show some visible feedback when a duplicate is detected.
I have tried to make a mock-up of the pop-up below:
image
Don't mind the sloppy design ;)

@markusfisch
Copy link
Owner

Sorry for the late response. It would sure be possible to add such a dialog!

Currently there are two settings for ignoring duplicates: The app can ignore duplicates that happen directly after each other or avoid any duplicate in the whole history. I think such a dialog would probably only be useful for the latter option.

Still, I am wondering if a dialog is the best choice here since it would require some user interaction. Which could get annoying, I'm afraid. So maybe a (toast) message would be better if you are just interested in when a duplicate was detected?

@gerryflux
Copy link
Author

Sure a toast notification could work. About the annoyance should it otherwise be a dialog box, that can be solved by having additional options in the settings under "Ignore Duplicates" such as:

  • Ignore Silently (how it works now)
  • Ignore with Toast Notification (your proposal)
  • Ignore with Dialog Option (the proposal)
    In the end the user chooses the level of 'annoyance' they want, as for me I don't mind it ;)

@markusfisch
Copy link
Owner

Well, with the existing three possibilties:

  • Consecutive duplicates
  • Any duplicates
  • Accept duplicates

This would result in something like this:

  • Consecutive duplicates (silent)
  • Consecutive duplicates (toast)
  • Consecutive duplicates (dialog)
  • Any duplicates (silent)
  • Any duplicates (toast)
  • Any duplicates (dialog)
  • Accept duplicates

Feels a bit like feature creep to me 😉 Of course, the silent/toast/dialog option could be another setting.

@gerryflux
Copy link
Author

Sure, that'd be a lot to take in and ruin the simplistic nature of the app:
What I'd propose would be a re-organisation of the feature:

  1. Renaming the Feature
    Ignore Duplicates ❌
    Duplicates ✅

Under the Feature, I'd keep these options

  • Accept (with toast - always nice to have visual/audio/haptic feedback 😉)
  • Ignore
    • Ignore (Toast) - this would play two roles, silent and notify - while also not affecting the overall flow of use.
    • Ignore (Dialog) - this would offer the flexibility to choose whether to "Skip" or "Add Anyway"

I have tried to design a mockup for it to show what I mean:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants