Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in regex in method that includes hash value to filename #15

Open
tray2002 opened this issue Jan 7, 2019 · 3 comments
Open

Bug in regex in method that includes hash value to filename #15

tray2002 opened this issue Jan 7, 2019 · 3 comments

Comments

@tray2002
Copy link

tray2002 commented Jan 7, 2019

On line 30 in index.js there is not escaped dot (.) in (.min):
const match = existingFileName.match(/-([0-9a-f]+)(.min)?(.\w+)(.map)?$/);

which results to append hash value before any 'min' text such as 'dmin' in 'admin'.

@markshapiro
Copy link
Owner

thanks for noticing, fixed it.

@tray2002
Copy link
Author

tray2002 commented Jan 7, 2019

Sorry to bother, but there is another (.min) in line 76. Could you fix it too?

@markshapiro
Copy link
Owner

yes, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants