diff --git a/Release_Protocol.md b/Release_Protocol.md index f3163cf403..c93c039a48 100644 --- a/Release_Protocol.md +++ b/Release_Protocol.md @@ -278,5 +278,5 @@ Update the following files in the BIDS website repository (https://github.com/bi ### 12. Sharing news of the release -Please share news of the release on the [identified platforms](https://docs.google.com/spreadsheets/d/16SAGK3zG93WM2EWuoZDcRIC7ygPc5b7PDNGpFyC3obA/edit#gid=0). +Please share news of the release on the [identified platforms](https://github.com/bids-standard/bids-specification?tab=readme-ov-file#BIDS-communication-channels). Please use our previous release posts as a guide. diff --git a/pdf_build_src/remove_admonitions.py b/pdf_build_src/remove_admonitions.py index ddd2b636a1..1942f8b5b0 100644 --- a/pdf_build_src/remove_admonitions.py +++ b/pdf_build_src/remove_admonitions.py @@ -47,7 +47,7 @@ def remove_admonitions( counter += 1 continue - if not line.startswith(indent): + if line != "\n" and not line.startswith(indent): is_admonition = False if is_admonition: diff --git a/pdf_build_src/tests/data/expected/README.md b/pdf_build_src/tests/data/expected/README.md index e719b45f38..37fadc295d 100644 --- a/pdf_build_src/tests/data/expected/README.md +++ b/pdf_build_src/tests/data/expected/README.md @@ -19,3 +19,14 @@ Collapsible admonitions start with 3 questions marks (`???`). Collapsible admonitions that will be shown as expanded start with 3 questions marks and a plus sign (`???+`). + + + +Let's see + +- [`UK biobank`](https://github.com/bids-standard/bids-examples/tree/master/genetics_ukbb) +- foo bar [`UK biobank`](https://github.com/bids-standard/bids-examples/tree/master/genetics_ukbb) + +More of the admonition + +And here we resume normal thing. diff --git a/pdf_build_src/tests/data/input/README.md b/pdf_build_src/tests/data/input/README.md index 102f731fc6..cab4817282 100644 --- a/pdf_build_src/tests/data/input/README.md +++ b/pdf_build_src/tests/data/input/README.md @@ -25,3 +25,16 @@ come in different type. In aaddtion of the classical admonitions show above you Collapsible admonitions that will be shown as expanded start with 3 questions marks and a plus sign (`???+`). + + + +!!! example "non ordered list should be handle propeler" + + Let's see + + - [`UK biobank`](https://github.com/bids-standard/bids-examples/tree/master/genetics_ukbb) + - foo bar [`UK biobank`](https://github.com/bids-standard/bids-examples/tree/master/genetics_ukbb) + + More of the admonition + +And here we resume normal thing. diff --git a/src/common-principles.md b/src/common-principles.md index f56f420c08..1b8c09a407 100644 --- a/src/common-principles.md +++ b/src/common-principles.md @@ -238,10 +238,14 @@ distinguish partial results from the raw data and share the latter. See [Storage of derived datasets](#storage-of-derived-datasets) for more on organizing derivatives. -Similar rules apply to source data, which is defined as data before -harmonization, reconstruction, and/or file format conversion (for example, E-Prime event logs or DICOM files). -Storing actual source files with the data is preferred over links to -external source repositories to maximize long term preservation, +Similar rules apply to source data, which is defined as data +before harmonization, reconstruction, and/or file format conversion +(for example, E-Prime event logs or DICOM files). +Retaining the source data is especially valuable +in a case when conversion fails to preserve crucial metadata +unique to specific acquisition setup. +Storing actual source files with the data is preferred over links +to external source repositories to maximize long term preservation, which would suffer if an external repository would not be available anymore. This specification currently does not go into the details of recommending a particular naming scheme for including different types of diff --git a/src/modality-specific-files/electroencephalography.md b/src/modality-specific-files/electroencephalography.md index 62d215e038..6ba02cc13a 100644 --- a/src/modality-specific-files/electroencephalography.md +++ b/src/modality-specific-files/electroencephalography.md @@ -42,14 +42,10 @@ It is RECOMMENDED to use the European data format, or the BrainVision data format. It is furthermore discouraged to use the other accepted formats over these RECOMMENDED formats, particularly because there are conversion scripts available in most commonly used programming languages to convert data into the -RECOMMENDED formats. The data in their original format, if different from the -supported formats, can be stored in the [`/sourcedata` directory](../common-principles.md#source-vs-raw-vs-derived-data). - -The original data format is especially valuable in case conversion elicits the -loss of crucial metadata specific to manufacturers and specific EEG systems. We -also encourage users to provide additional meta information extracted from the -manufacturer specific data files in the sidecar JSON file. Other relevant files -MAY be included alongside the original EEG data in `/sourcedata`. +RECOMMENDED formats. + +We encourage users to provide additional metadata extracted from the +manufacturer-specific data files in the sidecar JSON file. Note the `RecordingType`, which depends on whether the data stream on disk is interrupted or not. diff --git a/src/modality-specific-files/intracranial-electroencephalography.md b/src/modality-specific-files/intracranial-electroencephalography.md index 02fa4a189a..ae6a669a84 100644 --- a/src/modality-specific-files/intracranial-electroencephalography.md +++ b/src/modality-specific-files/intracranial-electroencephalography.md @@ -53,12 +53,8 @@ packages. Other formats that may be considered in the future should have a clear added advantage over the existing formats and should have wide adoption in the BIDS community. -The data format in which the data was originally stored is especially valuable -in case conversion elicits the loss of crucial metadata specific to -manufacturers and specific iEEG systems. We also encourage users to provide -additional meta information extracted from the manufacturer-specific data files -in the sidecar JSON file. Other relevant files MAY be included alongside the -original iEEG data in the [`/sourcedata` directory](../common-principles.md#source-vs-raw-vs-derived-data). +We encourage users to provide additional metadata extracted from the +manufacturer-specific data files in the sidecar JSON file. Note the RecordingType, which depends on whether the data stream on disk is interrupted or not. Continuous data is by definition 1 segment without interruption. diff --git a/src/modality-specific-files/microscopy.md b/src/modality-specific-files/microscopy.md index 2797781fa6..1b813f9eb2 100644 --- a/src/modality-specific-files/microscopy.md +++ b/src/modality-specific-files/microscopy.md @@ -59,9 +59,6 @@ Microscopy raw data MUST be stored in one of the following formats: - [OME-ZARR/NGFF](https://ngff.openmicroscopy.org/latest/) (`.ome.zarr` directories) -If different from PNG, TIFF, OME-TIFF, or OME-ZARR, the original unprocessed data in the native format MAY be -stored in the [`/sourcedata` directory](../common-principles.md#source-vs-raw-vs-derived-data). - ### Modality suffixes Microscopy data currently support the following imaging modalities: diff --git a/src/modality-specific-files/motion.md b/src/modality-specific-files/motion.md index 6ca4c81dfb..f0bbcb96ef 100644 --- a/src/modality-specific-files/motion.md +++ b/src/modality-specific-files/motion.md @@ -50,10 +50,6 @@ The number of columns in `_motion.tsv` files MUST equal the number of rows in the associated `_channels.tsv` file. All relevant metadata about a tracking systems is stored in accompanying sidecar `*_tracksys-