Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple checks without reloading are not working #80

Open
ostruk opened this issue Feb 18, 2016 · 0 comments
Open

Multiple checks without reloading are not working #80

ostruk opened this issue Feb 18, 2016 · 0 comments

Comments

@ostruk
Copy link

ostruk commented Feb 18, 2016

I wanted to perform multiple manifest checks without reloading the page. But what happens is that the library toggles the this._updateReady flag to true and never resets it back to false, even after the update is complete. The download function checks for this flag and if it's true, the download is skipped (the promise gets resolved to null). It would be prudent to set the this._updateReady flag to false once the update is complete so that a subsequent call to the download function succeeds.

Similarly, manifest files are being set to blank before download:

this.manifest.files = Manifest.files = {}

And will have to be set to new files after update is complete:

this.manifest.files = Manifest.files = this.newManifest.files;

I'll see if I can do a pull request..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant