Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation bug #19

Closed
ikok07 opened this issue Nov 9, 2023 · 2 comments · Fixed by #20
Closed

Animation bug #19

ikok07 opened this issue Nov 9, 2023 · 2 comments · Fixed by #20

Comments

@ikok07
Copy link

ikok07 commented Nov 9, 2023

When I launch my application for the first time the animation is not applied only to the redacted view but to the whole view:

This is my code:

ScrollView {
                    TodayFeaturedRecipesView()
                        .environmentObject(viewModel)
                        .tag(0)
                    
                    TodayStatisticsView()
                        .environmentObject(viewModel)
                        .padding(.top)
                    
                    if !(accManager.user?.isPremium ?? false) {
                        TodayFreeRecipesView()
                            .environmentObject(viewModel)
                        ExplorePremiumBannerView()
                            .redacted(reason: viewModel.isLoading ? .placeholder : [])
                            .shimmering(active: viewModel.isLoading, gradient: colorScheme == .dark ? K.Gradients.lightShimmeringGradient : K.Gradients.darkShimmeringGradient)
                    }
                }

image

image

@ast3150
Copy link
Contributor

ast3150 commented Nov 15, 2023

We had the same issue and were able to fix it by introducing the changes from #20

Can you try if this fix works for you as well?

@ikok07
Copy link
Author

ikok07 commented Nov 15, 2023

Yup, the issue was fixed! Thank you :)

@ikok07 ikok07 closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants