Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is 16px silently assumed instead of the actual font size? #9

Open
dmitriz opened this issue Apr 28, 2016 · 1 comment
Open

Why is 16px silently assumed instead of the actual font size? #9

dmitriz opened this issue Apr 28, 2016 · 1 comment

Comments

@dmitriz
Copy link

dmitriz commented Apr 28, 2016

I am puzzled why the hard-coded 16 is used:

https://github.com/markgoodyear/postcss-vertical-rhythm/blob/master/index.js#L11

Isn't it meant to work with any font size? Am I missing anything?

@ghost
Copy link

ghost commented Jun 1, 2016

I guess it's assuming only the font-size provided by the browser, which is by default 16 in most cases. And since it's working with the root size it doesn't matter if the user/developer uses another size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant