Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types and possible bug #239

Open
ELAD1010 opened this issue Oct 30, 2023 · 1 comment
Open

Types and possible bug #239

ELAD1010 opened this issue Oct 30, 2023 · 1 comment
Labels
insufficient information Needs submitter to provide more information as per CONTRIBUTING.md guidelines

Comments

@ELAD1010
Copy link

Hey,
I would like to add types for typescript support of your library.
In addition, I think I found a line of code that can fail some operations.
could you contact me about it?
@markabrahams markabrahams added the insufficient information Needs submitter to provide more information as per CONTRIBUTING.md guidelines label Jan 13, 2024
@markabrahams
Copy link
Owner

Hi @ELAD1010 - it's great that you're enthusiastic about adding TypeScript support to the library. Issue #129 is already opened for this, and a robust discussion about TypeScript support already exists under that issue, so it would be great if you joined the discussion in #129 with any TypeScript-related thoughts / ideas / implementations.

If you could provide information (minimal code reproduction, error message / condition, etc.) on the code failure, we could turn this issue into focusing on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
insufficient information Needs submitter to provide more information as per CONTRIBUTING.md guidelines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markabrahams @ELAD1010