Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobble without album #95

Open
MinmoTech opened this issue Oct 31, 2022 · 2 comments
Open

Scrobble without album #95

MinmoTech opened this issue Oct 31, 2022 · 2 comments

Comments

@MinmoTech
Copy link

I usually listen to songs on youtube or songs downloaded from youtube with mpv.

For the first few tracks the scrobbling fails with the error events::add_event:queue: skipping, track is invalid.
It works again if I go backwards in the queue.
While I don't know why that makes it work again, the original error is caused by line 392 in scrobble.h: strlen(m->album) > 0 &&.

Because my music is downloaded from youtube often does not have an associated album.

Would it be a possibility to remove that requirement?

@mariusor
Copy link
Owner

mariusor commented Feb 2, 2023

Hello @MinmoTech, first of all apologies for the very late reply.

Due to the fact that Last.fm requires an album name in both the now playing and scrobble API calls, we can't remove this check. Even if we remove it, your songs would still not show up on last.fm due to the missing information.

For the other services, maybe it's possible to remove the check, but I'm no longer actively working on this, and I would need confirmation form their API docs.

A patch/pull-request (accompanied by links to the docs where listenbrainz/librefm say they accept API calls without albums) would be welcome though.

@DhruvaSambrani
Copy link

Listenbrainz does not require album to be sent in the payload (release_name) - https://listenbrainz.readthedocs.io/en/latest/users/json.html#payload-json-details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants