include config.h in all sources

After we've been hit by Large File Support problems several times in
the past week (which only occur on 32 bit platforms, which I don't
have), this is yet another attempt to fix the issue.

Author: MaxKellermann

Makefile.am

@@ -29,6 +29,7 @@ src_mpd_LDADD = $(MPD_LIBS) \
 	$(GLIB_LIBS)
 
 mpd_headers = \
+	src/check.h \
 	src/notify.h \
 	src/ack.h \
 	src/audio.h \

configure.ac

@@ -101,6 +101,9 @@ dnl libc features
 dnl
 
 AC_SYS_LARGEFILE
+if test x$enable_largefile != xno; then
+	AC_DEFINE([ENABLE_LARGEFILE], 1, [Define if large file support is enabled])
+fi
 
 AC_CHECK_FUNCS(daemon fork syslog)
 if test $ac_cv_func_syslog = no; then

scripts/check_config_h.rb

@@ -0,0 +1,47 @@
+#!/usr/bin/env ruby
+#
+# This script verifies that every source includes config.h first.
+# This is very important for consistent Large File Support.
+#
+
+def check_file(file)
+    first = true
+    file.each_line do |line|
+        if line =~ /^\#include\s+(\S+)/ then
+            if $1 == '"config.h"'
+                unless first
+                    puts "#{file.path}: config.h included too late"
+                end
+            else
+                if first
+                    puts "#{file.path}: config.h missing"
+                end
+            end
+            first = false
+        end
+    end
+end
+
+def check_path(path)
+    File.open(path) do |file|
+        check_file(file)
+    end
+end
+
+if ARGV.empty?
+    Dir["src/*.c"].each do |path|
+        check_path(path)
+    end
+
+    Dir["src/*/*.c"].each do |path|
+        check_path(path)
+    end
+
+    Dir["test/*.c"].each do |path|
+        check_path(path)
+    end
+else
+    ARGV.each do |path|
+        check_path(path)
+    end
+end

src/archive/bz2_plugin.c

@@ -21,9 +21,9 @@
   * single bz2 archive handling (requires libbz2)
   */
 
+#include "config.h"
 #include "archive_api.h"
 #include "input_plugin.h"
-#include "config.h"
 
 #include <stdint.h>
 #include <stddef.h>

src/archive/iso_plugin.c

@@ -21,6 +21,7 @@
   * iso archive handling (requires cdio, and iso9660)
   */
 
+#include "config.h"
 #include "archive_api.h"
 #include "input_plugin.h"
 

src/archive/zip_plugin.c

@@ -21,6 +21,7 @@
   * zip archive handling (requires zziplib)
   */
 
+#include "config.h"
 #include "archive_api.h"
 #include "archive_api.h"
 #include "input_plugin.h"

src/archive_list.c

@@ -17,10 +17,10 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "archive_list.h"
 #include "archive_api.h"
 #include "utils.h"
-#include "config.h"
 
 #include <string.h>
 #include <glib.h>

src/audio.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "audio.h"
 #include "audio_format.h"
 #include "audio_parser.h"

src/audio_parser.c

@@ -22,6 +22,7 @@
  *
  */
 
+#include "config.h"
 #include "audio_parser.h"
 #include "audio_format.h"
 

src/buffer.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "buffer.h"
 #include "chunk.h"
 #include "poison.h"

src/check.h

@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2003-2009 The Music Player Daemon Project
+ * http://www.musicpd.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#ifndef MPD_CHECK_H
+#define MPD_CHECK_H
+
+/*
+ * All sources must include config.h on the first line to ensure that
+ * Large File Support is configured properly.  This header checks
+ * whether this has happened.
+ *
+ * Usage: include this header before you use any of the above types.
+ * It will stop the compiler if something went wrong.
+ *
+ * This is Linux/glibc specific, and only enabled in the debug build,
+ * so bugs in this headers don't affect users with production builds.
+ *
+ */
+
+#ifndef PACKAGE_VERSION
+#error config.h missing
+#endif
+
+#if defined(__linux__) && !defined(NDEBUG) && defined(ENABLE_LARGEFILE) && \
+	defined(_FEATURES_H) && defined(__i386__) && \
+	!defined(__USE_FILE_OFFSET64)
+/* on i386, check if LFS is enabled */
+#error config.h was included too late
+#endif
+
+#endif

src/chunk.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "chunk.h"
 #include "audio_format.h"
 #include "tag.h"

src/client.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 
 bool client_is_expired(const struct client *client)

src/client_event.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 #include "main.h"
 

src/client_expire.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 
 static guint expire_source_id;

src/client_global.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 #include "conf.h"
 

src/client_idle.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 #include "idle.h"
 

src/client_list.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 
 #include <assert.h>

src/client_new.c

@@ -17,11 +17,11 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 #include "fifo_buffer.h"
 #include "socket_util.h"
 #include "permission.h"
-#include "config.h"
 
 #include <assert.h>
 #include <unistd.h>

src/client_process.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 
 #include <string.h>

src/client_read.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 #include "fifo_buffer.h"
 

src/client_write.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "client_internal.h"
 
 #include <assert.h>

src/cmdline.c

@@ -17,13 +17,13 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "cmdline.h"
 #include "path.h"
 #include "log.h"
 #include "conf.h"
 #include "decoder_list.h"
 #include "decoder_plugin.h"
-#include "config.h"
 #include "output_list.h"
 #include "ls.h"
 

src/command.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "command.h"
 #include "player_control.h"
 #include "playlist.h"
@@ -47,7 +48,6 @@
 #include "path.h"
 #include "replay_gain.h"
 #include "idle.h"
-#include "config.h"
 
 #ifdef ENABLE_SQLITE
 #include "sticker.h"

src/compress.c

@@ -21,6 +21,7 @@
  * Imported from AudioCompress by J. Shagam <[email protected]>
  */
 
+#include "config.h"
 #include "compress.h"
 
 #include <glib.h>

src/conf.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "conf.h"
 #include "utils.h"
 #include "tokenizer.h"

src/crossfade.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "crossfade.h"
 #include "pcm_mix.h"
 #include "chunk.h"

src/cue/cue_tag.c

@@ -1,3 +1,4 @@
+#include "config.h"
 #include "cue_tag.h"
 
 static struct tag*

src/cue/cue_tag.h

@@ -1,12 +1,13 @@
 #ifndef MPD_CUE_TAG_H
 #define MPD_CUE_TAG_H
 
-#include "config.h"
+#include "check.h"
 
 #ifdef HAVE_CUE /* libcue */
 
+#include "tag.h"
+
 #include <libcue/libcue.h>
-#include "../tag.h"
 
 struct tag*
 cue_tag_file(	FILE*,

src/database.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "database.h"
 #include "directory.h"
 #include "directory_save.h"
@@ -26,7 +27,6 @@
 #include "text_file.h"
 #include "tag.h"
 #include "tag_internal.h"
-#include "config.h"
 
 #include <glib.h>
 

src/dbUtils.c

@@ -17,6 +17,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "config.h"
 #include "dbUtils.h"
 #include "locate.h"
 #include "directory.h"

src/decoder/.#flac_plugin.c

@@ -0,0 +1 @@
+max@woodpecker.roonstrasse.net.11431:1257744648

src/decoder/_flac_common.c

@@ -21,6 +21,7 @@
  * Common data structures and functions used by FLAC and OggFLAC
  */
 
+#include "config.h"
 #include "_flac_common.h"
 #include "flac_metadata.h"
 #include "flac_pcm.h"

src/decoder/_ogg_common.c

@@ -21,8 +21,8 @@
  * Common functions used for Ogg data streams (Ogg-Vorbis and OggFLAC)
  */
 
+#include "config.h"
 #include "_ogg_common.h"
-#include "../utils.h"
 
 ogg_stream_type ogg_stream_type_detect(struct input_stream *inStream)
 {

src/decoder/_ogg_common.h

@@ -24,7 +24,7 @@
 #ifndef MPD_OGG_COMMON_H
 #define MPD_OGG_COMMON_H
 
-#include "../decoder_api.h"
+#include "decoder_api.h"
 
 typedef enum _ogg_stream_type { VORBIS, FLAC } ogg_stream_type;