-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from dggridr
to h3
hexagons
#31
Comments
Revisiting this. Here are ways forward I see:
2.2 is probably easiest. 1 would be a good service for the community in general. 2.1 is the most forward-looking. |
I have been working with a tool to display h3 grid data. It is a simple html+js+mapboxgl project that allows uploading of a .json file that contains pre-computed values for h3 hex grid indexes. If we can compute the indicies for each h3 grid then we can export a .json file compatible with this tool. |
The H3 viewer code is ready. @bbest : is converting the current code to calculate over h3 indices instead of dggriddr hexes easy? |
Hey @7yl4r, Your grid viewer looks pretty cool! The issue I was having with the H3 was with hexagons that cross the dateline (ie with vertices a little greater than 0 and a little less than 180 longitude). It's interesting how your viewer seems to alternate between the two: I made a little fix here for the H3 polygons with this little function For another approach building the hexagons, something like: |
Yeah, there is some javascript in the app that does something related to the dateline issue but obviously it isn't perfect. For obisindicators we don't need to display the hexagons though, I just want to calculate es50 for each h3 hex. |
Working to use H3 on the H3 branch. |
Next step: split anti-meridonal hexagons into two with same h3 ID and still simple See also: |
Please please please remove the dependency on |
I feel like there is some projection setting that will handle this hexagon wrapping issue that we are having on the h3 branch. Some discussion on this issue seems relevant. I am going to try playing with some of these sf features tomorrow. |
It works!!! I don't want to close this quite yet though because the builds are failing to build from the DESCRIPTION.
The remote is pointing to the correct repo though... so I don't know what the problem is. Is installation and function of |
I was able to do a fresh install without seeing the "can't install dependency h3" issue. I did run into some other complications as documented in 819f845, but none related to the installation issue in the github action. |
attempted fix for failing builds mentioned in #31
attempted fix for failing builds mentioned in #31
I'll give this a try sometime soon 🤞 |
I wonder if the issue here has to do with the mismatch between the repo name Lines 34 to 45 in 06e5d2f
|
That's the best theory so far. We may need to report this to the github action. I tried another syntax for the DESCRIPTION file and now there is a different error:
|
h3 grid calculations take forever. I wonder if https://josiahparry.com/projects/pkgs/h3o.html I don't think it would change a lot of the obisindicators package... |
Several of us have had issues getting
dggridr
to work properly. The DESCRIPTION file currently has this set up to build it from C source code. We could try taking a different approach.From Pieter:
We could also try using the H3 grid.
The text was updated successfully, but these errors were encountered: