-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mark cell as stale on comments/whitespace changes? #3140
Comments
This is a good suggestion, I think we can handle this. Are there any edge cases you can think of? Do any libraries work off comments? I know some work off documentation (like doctests), but those exist in triple quotes. |
AST compilation will leave doc strings, but strip normal comments. Most implementations would work on this. There are pep ignore and tidy comments, but that shouldn't alter execution |
@dmadisetti it would be nice to figure out "edited" on the frontend instead of a sever request python AST parsing would be the most reliable. I may try the code-mirror lezer ast parsing on the front end. Any thoughts / issues with that? |
Actually, we may still want it to be stale since its not "saved" yet. I have a branch exploring this: #3145 Maybe the coloring is different? Could add more confusion |
Could be backlogged until/ if server side model comes along. I agree that it probably doesn't merit its own endpoint Re save: could use an icon, or vscode uses a little bubble right? |
yea, we could. right now save only saves what has been run, not what has been written. we could keep that, but then you may have white space that is never gets saved |
Description
It would be nice to have cells not get marked as "stale" when I only change comments or add/remove whitespace lines.
Suggested solution
Here's an example. The original cell:
Changes that I don't want to make the cell marked as stale:
Alternative
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: