Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

First button not shown with bottomNavigationBar using a TabSelector #26

Open
Dev-Owl opened this issue Nov 9, 2020 · 7 comments
Open

Comments

@Dev-Owl
Copy link

Dev-Owl commented Nov 9, 2020

Hi,

First, thanks for the nice plugin from my point of view it's a good addition when it comes to usability and quick navigation.

I'm facing an issue that the first button in my list is hidden, it is drawn under the "bottomNavigationBar" which is in my case a TabSelecgtor widget. The image below shows the situation:

menu

This is the code of the menu, please note the page is nested into another view using Scaffold to render the above mentioned bottom bar.

Scaffold(
        body: ListView(
          children: listItems,
        ),
        floatingActionButton: state is ProjectHomeEditDetailsState
            ? null
            : Builder(
                builder: (context) => FabCircularMenu(
                  key: fabKey,
                  ringWidth: 50,
                  alignment: Alignment(1, 1),
                  ringDiameter: min(MediaQuery.of(context).size.width,
                          MediaQuery.of(context).size.height) *
                      0.9,
                  children: <Widget>[
                   //Not shown
                    IconButton(
                        icon: Icon(Icons.delete_forever),
                        onPressed: () {},
                       ),
                    // All below are shown
                    IconButton(
                        icon: Icon(Icons.edit),
                         onPressed: () {},
                     ),
                    IconButton(
                      icon: Icon(Icons.search),
                      onPressed: () {},
                    ),
                    IconButton(
                      icon: Icon(Icons.sync),
                      onPressed: () {},
                    ),
                  ],
                ),
              ),
      );
@orachide
Copy link

Hello,

Did tou solved that?

@Dev-Owl
Copy link
Author

Dev-Owl commented Dec 19, 2020

If you consider adding a dummy button as a fix than yes. I did not really invest time into it as I'm just playing around with a few UI/UX concepts...

@MrCsabaToth
Copy link
Contributor

Interesting. I've found this: https://stackoverflow.com/questions/57831347/scaffold-bottomnavigationbar-overlapping-body-content-how-to-prevent-it
So unlike the AppBar the bottom navigation bar can overlay stuff. I'm not sure if this is the jurisdiction of the FabCircularMenu widget or not. There could be anything at the bottom.

@MrCsabaToth
Copy link
Contributor

Or maybe this is about Z order. When the Circular Fab Menu is on the topLeft or topRight it also overlays with the AppBar, however in that case the button and the circular ribbon are above the AppBar. In case of the bottom navigation bar it looks like it's in a broken state: the Circular Menu open close button seems to know that the bottom nav bar is there, however the circular ribbon shouldn't flow bellow the bar. So maybe it is somehow indeed the jurisdiction of the plugin, or both?

MrCsabaToth added a commit to CsabaConsulting/fab_circular_menu_plus that referenced this issue May 28, 2021
@YDA93
Copy link

YDA93 commented Mar 24, 2022

I fixed it by adding dummy widgets.

Example:

  children: [
    const SizedBox.shrink(),
    const SizedBox.shrink(),
    MainWidget(),
    const SizedBox.shrink(),
    const SizedBox.shrink(),
    MainWidget(),
    const SizedBox.shrink(),
    const SizedBox.shrink(),
  ],

@MrCsabaToth
Copy link
Contributor

My PR #35 is still not merged...

@YDA93
Copy link

YDA93 commented Mar 25, 2022

I noticed many packages has not recently accepted merges nor updating their pub.dev due to lack of funding I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants