Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all regression tests on Jenkins #12

Open
snukky opened this issue Sep 17, 2018 · 9 comments
Open

Run all regression tests on Jenkins #12

snukky opened this issue Sep 17, 2018 · 9 comments

Comments

@snukky
Copy link
Member

snukky commented Sep 17, 2018

I have lightened most tests by decreasing mini/maxi-batch sizes and reducing the length of test inputs wherever appropriate, but at the moment, only a few CPU and GPU tests are run on Jenkins.

However, some tests generate wrong textual output for me. @hieuhoang Does all tests work for you?

@snukky
Copy link
Member Author

snukky commented Sep 17, 2018

Mini/maxi-batches have been reduced because on Jenkins machine there is usually only 4GB GPU memory available.

@hieuhoang
Copy link
Collaborator

hieuhoang commented Sep 17, 2018 via email

@hieuhoang
Copy link
Collaborator

these 2 as well
test_en_de_gpu.return-nematus-alignment/
test_en_de_gpu.return-soft-alignment
There is textual difference

@hieuhoang
Copy link
Collaborator

Probably my fault.haven't checked reg tests in a while. Will take a look

@snukky
Copy link
Member Author

snukky commented Sep 18, 2018

OK. Jenkins jobs work now properly. @hieuhoang To add more tests to Jenkins (which we should do), just update TESTS_CPU and TESTS_GPU variables in the main Makefile.

@hieuhoang
Copy link
Collaborator

cheers. so only 3 GPU test pass on Jenkins? that's weird.

Is the GPU particularly old, with only 4GB? I don't have access/never used Jenkins.

Most tests pass on my GTX1080 (apart from 4 mentioned above), I'll make sure all tests pass when I have time. Then we will go from there

@snukky
Copy link
Member Author

snukky commented Sep 18, 2018

No, I added only 3 tests to be run on Jenkins to check if everything is configured correctly. I wasn't sure which tests are designed for GPU, and which for CPU as only some tests have gpu/cpu in their names. Maybe we should run all tests on both CUDA and CPU-only amun?

@snukky
Copy link
Member Author

snukky commented Sep 18, 2018

On the Jenkins machine these tests fail:

tests/ensemble.return-nematus-alignment/err:make[1]: [test] Error 1 (ignored)
tests/ensemble.return-soft-alignment/err:make[1]: [test] Error 1 (ignored)
tests/large-model/err:make[1]: [test] Error 1 (ignored)
tests/test_en_de_gpu.return-nematus-alignment/err:make[1]: [test] Error 1 (ignored)
tests/test_en_de_gpu.return-soft-alignment/err:make[1]: [test] Error 1 (ignored)

@hieuhoang
Copy link
Collaborator

Yep. They fail locally too. Will look at out next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants