Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When showing for the first time, if min > 0 and value = undefined, input spinners show the min value in black instead of the placeholder in grey #34

Open
taeh98 opened this issue Feb 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@taeh98
Copy link
Contributor

taeh98 commented Feb 11, 2021

I have a few spinners that I initialise as undefined instead of a defined numeric value, since I don't want them to be defined by default. Some of them have min values <= 0 and one has a min value > 0. When they first show (and all have their initial values, so value = undefined), the spinners with a min <= 0 show the placeholder in grey. This is my desired behaviour. The spinner with a min > 0, however, shows its min value in black. This is not my desired behaviour and is inconsistent with the behaviour of the spinners whose min values <= 0. The spinner with a min > 0 should also show the placeholder in grey when it first shows if it is undefined. Please could you fix this: make all input spinners have the desired behaviour?

I have tested this setting min to 0, 0.0, -1, -1.0, getting the desired behaviour, and to +1, +1.0, +10, and +10.0, getting the undesired behaviour. The step value was always +0.1, the max value was always +100.0, and the type value was always "float". I made sure to set the emptied prop to true and that I was using version 1.4.8 of this package.

@marcocesarato marcocesarato added the bug Something isn't working label Feb 11, 2021
@taeh98
Copy link
Contributor Author

taeh98 commented Feb 15, 2021

Although I meant to use it for another issue, this video I recorded shows how when min > 0 and the value is initialised as undefined, the value is shown as the min instead of being empty and showing the placeholder (as well as some other undesired behaviour): #35 (comment)

The spinner in question still behaves like this even after resolving the issues I had updating this package to allow me to align spinners how I want to.

@denisvely
Copy link

Any updates on this one?

I want to prefill negative value in the spinner and it`s not showing.
Also it has problem on spinning when the value is negative?

I will be glad if someone tell me for some workarounds.
Thank in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants