Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subject show command #180

Open
maxwai opened this issue Nov 14, 2023 · 4 comments · May be fixed by #197
Open

Add subject show command #180

maxwai opened this issue Nov 14, 2023 · 4 comments · May be fixed by #197
Assignees
Labels
Command Adds a command Prio 2
Milestone

Comments

@maxwai
Copy link
Collaborator

maxwai commented Nov 14, 2023

Add command to show all available subject for a user in a list with indexes

@maxwai maxwai added Command Adds a command Prio 2 labels Nov 14, 2023
@maxwai maxwai added this to the SS23 milestone Nov 14, 2023
@byte-sized-emi
Copy link
Collaborator

byte-sized-emi commented Feb 7, 2024

How are the indices for this list generated? They need to be generated by some deterministic algorithm in order for the subject add/rm commands to function with indices (#181 ), but I'm not sure how to do this best (maybe sorting the names alphabetically?)

Edit: Also, the logic of which subjects are shown to a user isn't detailed anywhere, as far as I can tell

@maxwai
Copy link
Collaborator Author

maxwai commented Feb 8, 2024

Ah yes I forgot that. The index (id) should be saved in the database. I will add it to the database as an incrementing int. Then this will be used for indexing.

As for the logic, one can look at the python code, but in a nutshell: Say a user is in study group IF3, then he will have access to all subjects that are linked with IF3 and also all semesters below, so IF2 and IF1

@byte-sized-emi
Copy link
Collaborator

I'll add it to the database myself because I've already started working on the command, and I'd say that it's in the scope of this issue.

@maxwai
Copy link
Collaborator Author

maxwai commented Feb 8, 2024

Yes works too

@byte-sized-emi byte-sized-emi linked a pull request Feb 10, 2024 that will close this issue
4 tasks
@maxwai maxwai linked a pull request Feb 11, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command Adds a command Prio 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants