New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasErrors is hard-coded to false for at least GitLab and Jenkins #203

Open

darraghjones opened this issue Nov 4, 2019 · 0 comments

Labels

enhancement up-for-grabs

darraghjones commented Nov 4, 2019

hasErrors is not set correctly. Therefore errorsFirst does not work correctly.

https://github.com/marcells/node-build-monitor/blob/master/app/services/GitLab.js#L103

https://github.com/marcells/node-build-monitor/blob/master/app/services/Jenkins.js#L172

marcells added enhancement up-for-grabs labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment