Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide CSS hides/disables checkboxes? #287

Open
thisisaaronland opened this issue Jul 5, 2016 · 3 comments
Open

Styleguide CSS hides/disables checkboxes? #287

thisisaaronland opened this issue Jul 5, 2016 · 3 comments
Labels

Comments

@thisisaaronland
Copy link
Member

thisisaaronland commented Jul 5, 2016

Form checkboxes appear to be hobbled in styleguide.css - specifically they are not rendered in the HTML, but trigger mouseover events and it seems like you can click them but it's never entirely clear whether the DOM is being updated.

With styleguide.css:

screen shot 2016-07-05 at 10 47 26

Without styleguide.css:

screen shot 2016-07-05 at 10 46 30

You can see the problem in action here:

https://whosonfirst.mapzen.com/lampzen/api/keys/register/

You'll need to be authed via Mapzen SSO but the code should take care of bouncing you through all the SSO stuff.

I can reproduce this in both FF and Safari.

@migurski
Copy link
Contributor

migurski commented Jul 5, 2016

Looks to be an actual bug.

@migurski migurski added the bug label Jul 5, 2016
@binx
Copy link
Contributor

binx commented Jul 5, 2016

having a difficult time with auth-ing in, but I'm guessing this is the same thing about using the ::after selector on CSS, and there's nothing else in the same wrapper for the CSS to attach to.

there's text on the stylesheet about how the CSS works, but if we just want it to work for whatever combination of DOM elements people add an we should get rid of the images and do plain unstyled checkboxes

@thisisaaronland
Copy link
Member Author

A few comments:

  • Docs... oh, huh. My bad.
  • That said, having to need to read docs to ensure that common HTML form elements work seems not-ideal.
  • But mostly this phrase: The checkbox pattern uses a background image to act as the checkbox. To make it appear... just screams all kinds of accessibility problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants