Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop inserting calculated values into layer features #37

Open
cudmore opened this issue May 25, 2022 · 0 comments
Open

Stop inserting calculated values into layer features #37

cudmore opened this issue May 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cudmore
Copy link
Member

cudmore commented May 25, 2022

We do not want to contaminate a users layer with additional features that may conflict with existing features.

Instead, store these calculated values directly in our pandas dataframe (e.g. our tableview model).

We will still grab all pre-existing layer.features and add them to our table. We just won't add any new ones to the layer itself.

Users can still get copies of these calculated columns with copy table.

For example, see:

  • _my_layer.pointsLayer._updateFeatures()
  • _my_layer.shapesLayer._updateFeatures()

In the above, we assign to the layer.features. This is where we need to store this calculated value internally in _my_layer or the pandas data model?

This is what we need to get rid of:

self._layer.features.loc[selectedList, 'x'] = self._layer.data[selectedList,2]
@cudmore cudmore added the enhancement New feature or request label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant