Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail: Wanted but not invoked: geoJsonSource.setGeoJson #17

Open
louwers opened this issue Feb 27, 2023 · 1 comment
Open

Tests fail: Wanted but not invoked: geoJsonSource.setGeoJson #17

louwers opened this issue Feb 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@louwers
Copy link
Collaborator

louwers commented Feb 27, 2023

After merging #12, the tests fail: https://github.com/maplibre/maplibre-plugins-android/actions/runs/4255578822/jobs/7403370903

com.mapbox.mapboxsdk.plugins.annotation.FillManagerTest > testInitialization FAILED
    Wanted but not invoked:
    geoJsonSource.setGeoJson(
        <any com.mapbox.geojson.FeatureCollection>
    );
    -> at com.mapbox.mapboxsdk.style.sources.GeoJsonSource.setGeoJson(GeoJsonSource.java:291)
    Actually, there were zero interactions with this mock.
        at com.mapbox.mapboxsdk.style.sources.GeoJsonSource.setGeoJson(GeoJsonSource.java:291)
        at com.mapbox.mapboxsdk.plugins.annotation.FillManagerTest.testInitialization(FillManagerTest.java:68)

We should set up CI for pull requests so that we avoid this in the future.

@louwers louwers added the bug Something isn't working label Feb 27, 2023
@JonasVautherin
Copy link
Collaborator

Was solved in #35 by removing the tests. Would be nice to actually fix them, but that's more involved following #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants