Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmaps are rendered differently with and without 3D terrain active #5238

Open
sebstryczek opened this issue Dec 18, 2024 · 2 comments
Open
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed terrain

Comments

@sebstryczek
Copy link

maplibre-gl-js version:

  • 4.7.1
  • 5.0.0-pre.10
  • probably different versions as well

browser: Chrome Version 131.0.6778.86 (Official Build) (x86_64) (MacOS, Intel)

Steps to Trigger Behavior

  1. Add heatmap
  2. Switch between 3D terrain active/inactive

Link to Demonstration

  1. https://jsbin.com/bekorug/edit?html,js,output - minimal example
  2. https://jsbin.com/turikuw/edit?html,js,output - using heatmap-globe-terrain.html

Expected Behavior

Heatmaps are rendered the same (or at least similar) with and without 3D terrain active.

Actual Behavior

  1. Heatmaps are rendered differently when 3D terrain is active.
  2. Some heatmap areas are not continuous across tile borders when 3D terrain is active (they are not blended).
    3D terrain inactive:
    Image
    3D terrain active:
    Image
@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed terrain labels Dec 18, 2024
@HarelM
Copy link
Collaborator

HarelM commented Dec 18, 2024

Thanks for taking the time to report this issue!
There were some attempts to fix the heatmap in regards to terrain, I'm not sure what was the final outcome.

CC: @Samarth1696

@Samarth1696
Copy link
Contributor

This behavior seems to be the default when the heatmap is calculated based on terrain elevation. I think maybe we can keep terrain elevation zero when we have zoomed out to a zoom level with "globe+terrain".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed terrain
Projects
None yet
Development

No branches or pull requests

3 participants