Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geojson Line Layer has lines on tile boundaries #5084

Open
dennemark opened this issue Nov 20, 2024 · 7 comments
Open

Geojson Line Layer has lines on tile boundaries #5084

dennemark opened this issue Nov 20, 2024 · 7 comments
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed

Comments

@dennemark
Copy link
Contributor

maplibre-gl-js version: 5.0.0-pre7

browser: Firefox

Steps to Trigger Behavior

  1. Use a GeoJson Line Layer that is bigger than a normal tile
  2. Tile boundaries are visible on different zoom levels
Bildschirmaufzeichnung.vom.2024-11-20.17-55-16.mp4

Link to Demonstration

Can prepare a demonstration tomorrow

Expected Behavior

No Lines on tile boundaries

Actual Behavior

Lines on tile boundaries

I could not find this issue yet, going to try to reproduce it tomorrow in a jsbin, but if someone is already working on it, let me know.

@HarelM
Copy link
Collaborator

HarelM commented Nov 20, 2024

I think this was discussed to some extent here:

And also here I think:

Please see if these are similar or not...

@HarelM HarelM added the need more info Further information is requested label Nov 20, 2024
@dennemark
Copy link
Contributor Author

I think it is a new issue, since the other issues refer to older versions and I could not reproduce it there.

Version 4.7.1
https://jsbin.com/qeliceyuvo/edit?html,output

Version 5.0.0-pre6
https://jsbin.com/piwazozego/1/edit?html,output

When scrolling in and out the issue sometimes appears. I am not sure if the issue is worse on version pre.7, since I could not use in yet on jsbin. But in the reproduction the issue is less strong than in my video, where lines stay. In my video I also use a custom babylon layer. Tried to use it in the reproduction, but did not change anything yet. However, the issue is still visible.
I have to check if this only happens when using globe projection in my case. Since in the reproduction it seems like, the issue is only visible then.

What I missed to mention: Terrain is used.

@HarelM
Copy link
Collaborator

HarelM commented Nov 21, 2024

This is different than the following issue, right?

@dennemark
Copy link
Contributor Author

Ok I could reproduce the issue:
https://jsbin.com/zikemabepu/1/edit?html,output

To always see the issue, the terrain resolution has to be set to 512 in the jsbin. 256 seems to be the correct resolution! But the issue still appears, just not that often. So for reproduction maybe it is useful to use the 512px.

@dennemark
Copy link
Contributor Author

This is different than the following issue, right?

* [Globe: Flickering and missing layers when panning/zooming #5025](https://github.com/maplibre/maplibre-gl-js/issues/5025)

If I read it correctly, the other issue does not appear, when terrain is enabled. So it most probably is not related.

@HarelM
Copy link
Collaborator

HarelM commented Nov 21, 2024

I see the issue, thanks!

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed and removed need more info Further information is requested labels Nov 21, 2024
@pcardinal
Copy link
Contributor

What should we see according to your site url https://web3d.basemap.de/maplibre/dgm5-rgb/{z}/{x}/{y}.png ?
I use it with QGIS and it only produces errors with a blank screen.

Image
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants