Ensure controls respect padding #8670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this to declutter our queue. I haven't had the time to work on it recently, will reopen once I have more progress. |
added 2 commits
February 14, 2020 18:58
arindam1993
force-pushed
the
asymmetric-viewport-controls
branch
from
4b105fc
to
a9aad3c
Compare
arindam1993
force-pushed
the
asymmetric-viewport-controls
branch
2 times, most recently
from
6336a49
to
29a7ca3
Compare
|
After having worked on the example in https://github.com/mapbox/mapbox-gl-js-docs/pull/248, I feel that this feature needs a lot more fine-grained control than what this PR offers. Also it would be more performant to achieve this via css transitions on the control containers, which would be easier for developers to implement based on the template in the example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up to #8638, and updates the styling of
Map#_controlPositionsDOM elements to respect the current state ofpadding.I'm not completely sure if this should be default behavior, or a option that defaults to true.
Demo:
Launch Checklist
post benchmark scorestagged@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changestagged@mapbox/gl-nativeif this PR includes shader changes or needs a native port