Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for rasterarray source #13237

Closed
wants to merge 4 commits into from
Closed

Docs for rasterarray source #13237

wants to merge 4 commits into from

Conversation

pratikyadav
Copy link
Contributor

@pratikyadav pratikyadav commented Jul 23, 2024

This PR adds JSDocs comment for rasterarray source

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@pratikyadav pratikyadav marked this pull request as ready for review July 23, 2024 15:50
@pratikyadav pratikyadav requested a review from a team as a code owner July 23, 2024 15:50
rreusser
rreusser previously approved these changes Jul 23, 2024
Copy link
Contributor

@rreusser rreusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for adding. 🙇 Looks analogous to raster tile source, so I assume it has all the content it needs. Also, I assume this ends up live when GL JS is published?

src/source/raster_array_tile_source.ts Outdated Show resolved Hide resolved
@pratikyadav pratikyadav deleted the pratik/rasterarray_doc branch July 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants