Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(style-spec): remove unused sort-object dep #13209

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

AbhiPrasad
Copy link
Contributor

[email protected] isn't used anywhere, so removing it from deps. This eliminates the 23 KB / 18 deps that sort-object brings in when you download @mapbox/mapbox-gl-style-spec.

ref: https://npmgraph.js.org/?q=sort-object

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@AbhiPrasad AbhiPrasad requested a review from a team as a code owner June 29, 2024 18:35
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AbhiPrasad
Copy link
Contributor Author

Signed the CLA - thanks for the quick review!

@mourner mourner merged commit b813c19 into mapbox:main Jul 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants