Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify AnimationOptions#offset documentation – move to CameraOptions #4240

Open
mollymerp opened this issue Feb 9, 2017 · 1 comment
Open

Clarify AnimationOptions#offset documentation – move to CameraOptions #4240

mollymerp opened this issue Feb 9, 2017 · 1 comment
Assignees
@SnailBones
Labels
docs 📜

Comments

@mollymerp
Copy link
Contributor

mollymerp commented Feb 9, 2017 •
edited
Loading

We have an existing solution to the top requested feature ( #1740 ) but it's not clear that we do because the docs on this option are confusing.

It is currently in AnimationOptions described as:

x and y coordinates representing the animation's origin of movement relative to the map's center.

I think it should be moved to CameraOptions because it affects the Map's positioning after an animation completes, and the documentation should be reworded so it is understandable by regular humans.
@mollymerp mollymerp mentioned this issue Feb 9, 2017
Closed
@ansis
Copy link
Contributor

ansis commented Jul 9, 2021

I agree that AnimationOptions is a weird place for this but I don't think we can change it anymore. #1740 has been fixed with PaddingOptions.

We still need to improve the doc for this property.

@ansis ansis mentioned this issue Jul 9, 2021
Closed
@HeyStenson HeyStenson mentioned this issue Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SnailBones SnailBones

Labels
docs 📜
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ansis @mollymerp @SnailBones