Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential null dereference in onRemove() #480

Open
angrytongan opened this issue Dec 22, 2022 · 0 comments
Open

Potential null dereference in onRemove() #480

angrytongan opened this issue Dec 22, 2022 · 0 comments

Comments

@angrytongan
Copy link

It's possible that parentNode is null, which causes a null dereference:

this.container.parentNode.removeChild(this.container);

This can occur if the geocoder adds itself to a map, then map.remove() is called, and then the geocoder tries to remove itself from the map.

angrytongan added a commit to angrytongan/mapbox-gl-geocoder that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant