Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds segment tracking for this Developer tool #906

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

AndrewSepic
Copy link
Contributor

@AndrewSepic AndrewSepic commented Nov 6, 2024

UPDATE

This PR adds an inline resource to our web-analytics script hosted at https://docs.mapbox.com/analytics.min.js to this dev tool. It sets up basic mbxMetadata to properly categorize this tool and initializes webAnalytics turning Marketo munchkin off in this instance.

// eslint-disable-next-line no-undef
initializeMapboxAnalytics({
  marketoMunchkin: false
});

This PR also removes older GA tracking codes which are no longer needed.

Screenshot 2024-11-06 at 3 54 07 PM

If approved, I will deploy this update via npm run deploy

@AndrewSepic AndrewSepic requested a review from a team as a code owner November 6, 2024 20:56
@AndrewSepic AndrewSepic self-assigned this Nov 6, 2024
@AndrewSepic AndrewSepic changed the title Adds segment tracking for this repo Adds segment tracking for this Developer tool Nov 6, 2024
@AndrewSepic AndrewSepic force-pushed the as/add-segment-tracking branch from 7dbbe29 to 571005d Compare November 7, 2024 19:56
Copy link
Contributor

@chriswhong chriswhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSepic AndrewSepic merged commit ab42b63 into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants