Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gnome Shell 45 and 46 compatibility. #101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

glerroo
Copy link

@glerroo glerroo commented Nov 4, 2023

Since ESM files contain import and export keywords, extension modules won't be compatible with older GNOME Shell versions. The old shell versions must be removed and only use 45 in shell-version in metadata.json!

Port Extensions to GNOME Shell 45

This close #99

image

image

…l Gi/GS imports.

* Gnome Shell is moving to ESM, it will load extensions as standard modules.
* We can also start using standard imports for introspected modules & Gnome
Shell imports.
* Convenience APIs for extensions are now provided as Extension base classes.
* initTranslations()	method is considered deprecated.
* GLib timeout is to prefer instead of Mainloop.
* ByteArray.toString() is deprecated we must use TextDecoder.decode() instead.
…all Gi/GS imports.

* This is an initial working port, but no use adwaita widgets amd styles.
@fewaltix
Copy link

fewaltix commented Dec 1, 2023

Thank you so much for this commit, can confirm that it works flawlessly with Gnome 45 and OpenSuse Tumbleweed!

@glerroo
Copy link
Author

glerroo commented Dec 5, 2023

For me work great with GS45, but i don't use OpenSuse Tumbleweed, eventually i create a vm and test it.

Copy link

@FelipeFTN FelipeFTN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @glerroo! 🚀

@glerroo
Copy link
Author

glerroo commented Dec 12, 2023

I tested it in an OpenSuse Tumbleweed VM, with Gnome Shell 45.1, and work great!!

image

@fewaltix
Copy link

@glerroo
I know! Just wanted to confirm it! Great work, thanks!

@glerroo
Copy link
Author

glerroo commented Feb 24, 2024

Issue #103 fixed.

Clutter.Container was removed.
Clutter.Container.add_actor() and Clutter.Container.remove_actor() are
deprecated and should use Clutter.Actor.add_child() and
Clutter.Actor.remove_child() instead.
@glerroo glerroo changed the title Add Gnome Shell 45 compatibility. Add Gnome Shell 45 and 46 compatibility. Mar 8, 2024
@ppw0
Copy link

ppw0 commented Jun 27, 2024

Can you submit your version to extensions.gnome.org?

@glerroo
Copy link
Author

glerroo commented Jul 8, 2024

@maoschanz Hi, thanks for the extension, can you take a look to this pr and eventually merge it, and submit a new version to extensions.gnome.org.

@tomleejumah
Copy link

im here because it stopped working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gnome 45 Support
5 participants