Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-importer doesn't find packages from other packages #232

Open
dietergeerts opened this issue May 25, 2021 · 1 comment
Open

package-importer doesn't find packages from other packages #232

dietergeerts opened this issue May 25, 2021 · 1 comment

Comments

@dietergeerts
Copy link

dietergeerts commented May 25, 2021

My node modules don't get installed in a flat tree, but as an actual dependency tree where only the ones that are specified are installed, which is very good (I use pnpm) So the package structure I have is:

- my-package
|- node_modules
  |- my-toolkit
    |- node_modules
      |- bootstrap

Because of this, the importer can't find the bootstrap imports declared in the toolkit scss files, as it always starts searching from the cwd and not from the file that is asking for the import, which is a node_modules deeper. The importer should check which file loaded it (https://sass-lang.com/documentation/js-api#importer) and based on that set the starting directory to search in.

(another issue I encounter is that index.scss isn't resolved if you only state the directory, which does work normally with sass and sass-loader)

@mpdude
Copy link

mpdude commented Jan 27, 2022

Is that a duplicate of #188?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants