New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computeDestinationPoint uses a different hardcoded earth radius value instead of the constant #290

Open

pleblancq opened this issue Oct 7, 2022 · 1 comment

pleblancq commented Oct 7, 2022 •

edited

Loading

in computeDestinationPoint.ts

const computeDestinationPoint = (
    start: GeolibInputCoordinates,
    distance: number,
    bearing: number,
    radius: number = 6371000
) => {

instead of using export const earthRadius = 6378137; from constants.ts

this issue appeared in v2.0.25

The text was updated successfully, but these errors were encountered:

nacho-skydweller mentioned this issue

Avoid using a hard coded earth radius in compute destination point #296

Open

nacho-skydweller commented Mar 13, 2023

I submitted PR #296 to fix this, could someone give it a review and merge when possible please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment