Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - out of date package torus stepping on global #257

Open
ianlivingstone opened this issue Jun 2, 2017 · 4 comments
Open

Bug - out of date package torus stepping on global #257

ianlivingstone opened this issue Jun 2, 2017 · 4 comments

Comments

@ianlivingstone
Copy link
Contributor

If you have installed Torus globally (using brew install or npm install -g), and then install torus locally as a package in your package.json. If the versions between the two get out of sync they'll step on one another resulting in a user always being asked to login.

@ianlivingstone
Copy link
Contributor Author

I'm not exactly sure what we can do to fundamentally solve this bug, as the script (e.g. npm start ) will use the version of Torus in node_modules but a user would use the globally installed one.

We can make it less likely to happen by separating out version from protocol, but it wouldn't fundamentally solve this bug.

@ianlivingstone
Copy link
Contributor Author

Thoughts @jbowes @mattcreager ?

@johnstonmatt
Copy link

Does a session need to be invalidated on upgrade? and if it does, maybe the versions are locked symetrical via package-lock.json or yarn.lock

@ianlivingstone
Copy link
Contributor Author

Does a session need to be invalidated on upgrade? and if it does, maybe the versions are locked symetrical via package-lock.json or yarn.lock

A session is not stored on disk, instead, it's kept in memory inside the torus daemon. When an upgrade happens and the daemon is restarted the session is lost!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants