Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor entity/datasenders/ implementation approach (All datasenders page) #1

Open
asifmom opened this issue Feb 4, 2012 · 0 comments

Comments

@asifmom
Copy link
Member

asifmom commented Feb 4, 2012

javascript datasenders/index.js needs to be improved. for example the handler for web_user_creation is very complex. It trys to parse the message from the view and guess where is the email id : (json_data.errors[i].split(' ')[3])

further examples :

       data_sender.short_name = $($(row).children()[2]).html();
        data_sender.name = $($(row).children()[1]).html();
        data_sender.location = $($(row).children()[4]).html();
        data_sender.contactInformation = $($(row).children()[6]).html();
        data_sender.email = $($(row).children()[7]).html();

Appropriate json could be passed directly from the views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant