Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions required? #25

Open
Matir opened this issue Nov 16, 2020 · 2 comments
Open

Permissions required? #25

Matir opened this issue Nov 16, 2020 · 2 comments
Labels
question Further information is requested

Comments

@Matir
Copy link
Contributor

Matir commented Nov 16, 2020

Is there a meaningful difference between <all_urls> and "https://*/*", "http://*/*" in how this extension uses things? It would seem to preclude file://, ftp://, and chrome-extension:// URLs, though I believe it can still access its own extension resources.

@mandatoryprogrammer
Copy link
Owner

It would still be able to access its own origin (e.g. chrome-extension://randomextid, all extensions can with zero permissions declared), and I'm not sure there is a meaningful distinction here. Not sure how ftp:// works, but file:// you have to explicitly toggle a setting in the extension's specific chrome://extensions setting page which seems unlikely to happen/be part of an attack.

For 99% of use cases, I'd imagine if an extension has https://*/* and http://*/* then it's basically functionally equivalent to <all_urls>. Same for if someone used *://*/* (also a valid host match pattern apparently).

Were you thinking the docs should be a bit more clear on this point?

@mandatoryprogrammer mandatoryprogrammer added the question Further information is requested label Nov 22, 2020
@Matir
Copy link
Contributor Author

Matir commented Nov 23, 2020

Yeah, it might not be bad. I thought (and in my own testing, it appears correct) that "https://*/*", "http://*/*" just works, but I was wondering if there was an edge case I was not considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants