-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System service always returns untranslated group names. #10
Comments
kkofler
added a commit
to kkofler/dnfdragora
that referenced
this issue
Nov 16, 2016
New file dnfdragora/compsicons.py, similar to groupicons.py, but for comps. New tool tools/gen-comps-category-list.sh: Generates a map from category name to ID for dnfdragora/compsicons.py, as a workaround for manatools/dnfdaemon#9. dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for each ID in an id_to_name_map. (mainGui._fillGroupTree): Handle comps separately, use compsicons.py to get the icons (manatools#2) and use the id_to_name_map to get the UI name (manatools#3). Fixes manatools#2. Fixes manatools#3. The only remaining issue is that the UI names are not translated, which I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and thus it is clearly dnfdaemon's fault).
This was referenced Nov 16, 2016
Conan-Kudo
pushed a commit
to manatools/dnfdragora
that referenced
this issue
Nov 16, 2016
New file dnfdragora/compsicons.py, similar to groupicons.py, but for comps. New tool tools/gen-comps-category-list.sh: Generates a map from category name to ID for dnfdragora/compsicons.py, as a workaround for manatools/dnfdaemon#9. dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for each ID in an id_to_name_map. (mainGui._fillGroupTree): Handle comps separately, use compsicons.py to get the icons (#2) and use the id_to_name_map to get the UI name (#3). Fixes #2. Fixes #3. The only remaining issue is that the UI names are not translated, which I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and thus it is clearly dnfdaemon's fault).
The dnf-daemon runs as a system daemon (LANG=c) so there should properly be some way to set the locale you want to use when getting the ui_name.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The user-visible name (DNF's
ui_name
) we get from the dnfdaemon system service (in the[1]
list entry of any comps group or category) is always returned in English rather than translated. This is strange because DNF itself translates these names, and the DNF API documentation says that these names are translated. But dnfdaemon is not setting the locale appropriately, probably because it is a system service, and I cannot find an API to set it manually.Should the applications ask the session daemon rather than the system daemon for the groups? Should they set the locale somewhere? (Where?) Yumex-DNF (unmodified Fedora package) and dnfdragora (even after my fix to use the
[1]
(ui_name
) entry in the UI instead of the[0]
(id
orname
) entry) both show me the groups in English whereas the DNF command line shows me German names.The text was updated successfully, but these errors were encountered: