Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Private key download disabled message #611

Closed
adammake opened this issue Mar 31, 2023 · 5 comments
Closed

[Safari] Private key download disabled message #611

adammake opened this issue Mar 31, 2023 · 5 comments
Assignees
Milestone

Comments

@adammake
Copy link
Member

adammake commented Mar 31, 2023

Due to a technical constraint, Safari users will not be able to download their imported secret key files in the Casper Wallet launch build. The long term fix will be addressed in #612. We need a simple solution to address the issue until the long term fix can be implemented.

Solution

1.1Messaging will be added to Casper Wallet to let users know that private keys cannot be downloaded. This message will only appear for Safari users.
In the import screen: "Please note, accounts imported with a file cannot be recovered using your Casper Wallet secret recovery phrase.
Important: After importing, private key files cannot be downloaded from Casper Wallet. Make sure to store a copy of your secret key file in a safe place.
image.png

1.2
Hide the "Download secret key file" in the Settings menu option.

@ost-ptk
Copy link
Member

ost-ptk commented Apr 6, 2023

Done #622

@piotrwitek piotrwitek added this to the 1.2.7 milestone Apr 6, 2023
@karatnyk
Copy link

@piotrwitek
Within build 1.3.0 "Private key download" functionality is disabled not only for Safari but for Firefox browser as well (though it worked on previous builds), could you please advise if this is expected?
firefox_tXRfTdy2Jx.gif

@piotrwitek
Copy link
Contributor

Thanks @karatnyk It should work on Firefox.
@ost-ptk could you have a look?

@karatnyk
Copy link

@piotrwitek
In that case, I'll move this ticket back to "In Progress".

@karatnyk
Copy link

Verified on latest 1.3.0 build as fixed, marking this ticket as "Done".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants