Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash handler does not close server connection #14

Open
VIZZI-DK opened this issue Mar 19, 2023 · 4 comments
Open

Crash handler does not close server connection #14

VIZZI-DK opened this issue Mar 19, 2023 · 4 comments

Comments

@VIZZI-DK
Copy link

Server connection not closed during CrashReport

@makamys
Copy link
Owner

makamys commented Mar 19, 2023

I need a log

@VIZZI-DK
Copy link
Author

By checking the code in MixinMinecraft.class
I didn't see a call anywhere.
Minecraft.getNetHandler().onDisconnect

No errors were found in the logs.
Hooked into Minecraft.freeMemory and called onDisconnect

@makamys
Copy link
Owner

makamys commented Mar 19, 2023

Oh, I misunderstood. I thought you were reporting a crash, but what you're saying is the server connection is not closed when CoreTweaks catches a crash. This is only an issue in multiplayer, right?

@VIZZI-DK
Copy link
Author

I didn't get a chance to test it in single player so I don't know.
In multiplayer, yes

@makamys makamys changed the title CrashReport Crash handler does not close server connection Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants